Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonRpcHttpService - Add BodyHandler limit size #5467

Merged
merged 9 commits into from
May 21, 2023
Merged

JsonRpcHttpService - Add BodyHandler limit size #5467

merged 9 commits into from
May 21, 2023

Conversation

Gabriel-Trintinalia
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented May 17, 2023 •
edited
Loading

PR description

Body Size Limit for BodyHandler in Vert.x Route: A limit on body size for the BodyHandler is introduced to prevent memory overuse and improve application robustness. (Set to 5MB)

--rpc-http-max-request-content-length overrides the limit.

@github-actions
Copy link

github-actions bot commented May 17, 2023 •
edited by Gabriel-Trintinalia
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review May 17, 2023 02:52
macfarla
macfarla approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia added mainnet TeamRevenant GH issues worked on by Revenant Team doc-change-required Indicates an issue or PR that requires doc to be updated RPC labels May 19, 2023
jframe
jframe approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) May 20, 2023 23:57
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit e4a8e1d into hyperledger:main May 21, 2023
@alexandratran alexandratran mentioned this pull request Jun 14, 2023
Closed
1 task
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 14, 2023
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@Gabriel-Trintinalia @elenduuche
JsonRpcHttpService - Add BodyHandler limit size (hyperledger#5467)
ed618e6 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the 5458-json-rpc-http-body-limit branch September 11, 2023 01:05
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@Gabriel-Trintinalia @eum602
JsonRpcHttpService - Add BodyHandler limit size (hyperledger#5467)
dc0cfe3 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
mainnet RPC TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel-Trintinalia @jframe @macfarla @alexandratran